[Explicit Module Builds] Refactor the InterModuleDependencyGraph to distinguish prebuilt external dependencies. #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istinguish prebuilt external dependencies. This is a refactoring change intended to reduce ambiguity in what nodes in the dependency graph can represent. As dependency graph structure and individual modules are being communicated and merged among different components, such ambiguities in the graph introduce additional, unnecessary complexity to graph operations. - Introduce a new module kind: `.swiftPrebuiltExternalDependency`. This node kind is to be used for external target dependencies built by build system clients such as SwiftPM. Previously we were using `.swift` modules to represent both pre-compiled external targets and Swift module dependencies that require a build job to be created by the driver. This new structure means that every `.swift` module dependency must have a build job constructed for it, and every `.swiftPrebuiltExternal` module dependency does not require to be built. - Factor out and unify common graph operations.
|
@swift-ci please test |
nkcsgexi
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring change intended to reduce ambiguity in what nodes in the dependency graph can represent. As dependency graph structure and individual modules are being communicated and merged among different components, such ambiguities in the graph introduce additional, unnecessary complexity to graph operations.
.swiftPrebuiltExternalDependency.This node kind is to be used for external target dependencies built by build system clients. Previously we were using
.swiftmodules to represent both pre-compiled external targets and Swift module dependencies that require a build job to be created by the driver. This new structure means that every.swiftmodule dependency must have a build job constructed for it, and every.swiftPrebuiltExternalmodule dependency does not require to be built.