Skip to content

[Parseable output] Implement SignalledMessage #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2019
Merged

[Parseable output] Implement SignalledMessage #30

merged 1 commit into from
Nov 1, 2019

Conversation

sjavora
Copy link
Contributor

@sjavora sjavora commented Oct 28, 2019

Implements SignalledMessage as another kind of ParsableMessage.

sjavora
sjavora commented Oct 28, 2019
View reviewed changes
@harlanhaskins harlanhaskins requested a review from aciidgh October 28, 2019 21:38
DougGregor
DougGregor reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking promising, thank you! In addition to the strsignal comment, have you tried this out through a consumer of parsable output, like Xcode? You can force the Swift compiler to crash with the extra Swift compile arguments -Xfrontend -debug-crash-after-parse to see.

@sjavora
Copy link
Contributor Author

sjavora commented Oct 30, 2019

have you tried this out through a consumer of parsable output, like Xcode?

I've gotten this output: error: Illegal instruction: 4 (in target 'TSCLibc' from project 'swift-driver')

It seems consistent with the existing driver.

@DougGregor
Copy link
Member

have you tried this out through a consumer of parsable output, like Xcode?

I've gotten this output: error: Illegal instruction: 4 (in target 'TSCLibc' from project 'swift-driver')

It seems consistent with the existing driver.

Great! Before your PR, it would silently fail in Xcode with no message.

@DougGregor
Copy link
Member

@swift-ci please test

@DougGregor DougGregor merged commit 92e6773 into swiftlang:master Nov 1, 2019
fengjixuchui referenced this pull request in fengjixuchui/swift-driver Nov 1, 2019
@fengjixuchui
Merge pull request #7 from apple/master
c5da327 
Merge pull request apple#30 from sjavora/signalled-message
@sjavora sjavora deleted the signalled-message branch February 6, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjavora @DougGregor