Replace 'ParsableMessage' factory methods with an initializer. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR applies the "avoid abbreviations" naming convention to the `msg:` argument label in `ParsableMessage.beganMessage(name:msg:)`, `ParsableMessage.finishedMessage(name:msg:)` and `ParsableMessage.signalledMessage(name:msg:)`.
|
What if we changed each of these methods to drop the redundant type name, move the |
|
I like that idea. But after giving some more thoughts to this, I think it might be better to drop these static methods and just use initializers instead, since it isn't more complicated: ParsableMessage(name: job.kind.rawValue, kind: .signalled(message))What do you think? |
|
That sounds great to me. |
rxwei
changed the title
|
Done. |
harlanhaskins
approved these changes
Nov 7, 2019
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses an initializer
init(name:kind:)to unify multiple factory methods.