Skip to content

Only link compiler_rt when dynamic linking #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

cltnschlosser
Copy link
Contributor

Fixes the darwin part of Driver/static-archive.swift. This test didn't check for this specifically, but it was testing for libtool -static and libclang_rt was in between that. Looked further and found c++ driver only includes libclang_rt when linking dynamically.

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you.

@artemcm
Copy link
Contributor

artemcm commented Nov 3, 2020

@swift-ci please test

@cltnschlosser cltnschlosser merged commit 09ca245 into swiftlang:main Nov 3, 2020
@cltnschlosser cltnschlosser deleted the cs_staticLinkingFix branch November 3, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants