Skip to content

Remove @_spi's that were preventing compilation #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

davidungar
Copy link
Contributor

The latest Swift compiler is less tolerant of @_spi's than before. Remove the offenders.
rdar://71381579

@davidungar
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unfortunate to have testable return to the code-base.
This, plus the recent discovery that in the absence of library-evolution, implementationOnly is also somewhat broken, are good motivators to get around to resolving issues with building swift-driver with library evolution.

@davidungar davidungar merged commit 6a47766 into swiftlang:main Nov 13, 2020
@davidungar davidungar deleted the rm-spis branch January 29, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants