Rely on libSwiftScan for dependency scanning actions.
#427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
So excited to see libSwiftScanner is used here to enhance build performance! Is it difficult to also preserve the old interaction form of JSON files? One benefit of that is we can get a peek inside the scanning process for debugging purposes. |
No, shouldn't be difficult. I'll add an option for this. |
|
@swift-ci please test |
artemcm
force-pushed
the
DependencyScanLib
branch
from
a897537 to
58f2a89
Compare
|
@swift-ci please test |
|
@swift-ci please test |
artemcm
force-pushed
the
DependencyScanLib
branch
from
58f2a89 to
ab7e09f
Compare
|
@swift-ci please test |
artemcm
force-pushed
the
DependencyScanLib
branch
from
b9388b0 to
b2326f9
Compare
|
@swift-ci please test |
4 similar comments
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
@nkcsgexi ping |
nkcsgexi
approved these changes
Feb 3, 2021
… libSwiftScan, instead of launching `swift-frontend` processes and capturing their output. - Adds target `CSwiftScan` that contains the C header which captures all the required symbols from `libSwiftScan`. - Adds a `SwiftScan` subdirectory in the `SwiftDriver` target which contains code responsible for interactiosn with `libSwiftScan`. - A wrapper class (`SwiftScan`) taking care of initialization, shutdown, and dispatching dependency scanning queries to a library instance. - A collection of utilities (in `DependencyGraphBuilder.swift`) to translate dependency scanning query inputs into the C library expected format and translate the dependency scanning output into the format the driver understands (`InterModuleDependencyGraph`).
Using a persistent libSwiftScan instance across targets of the same build allows us to forego the notion of a placeholder module. Instead of communicating a placeholder module for some external target `C` to the scanner, the scanner will have previously scanned `C` because targets are planned in dependency order. This means the scanner will have an entry for module `C` as a module to be built from source-code. The driver needs to detect external targets and update the dependency graph to represent them as binary pre-built modules, instead of building them once again.
…input filenames with quotes.
The latter subsumes the former's purpose now.
…tion" This reverts commit 00678f3. Placeholder resolution needs to stick around while SwiftPM transitions to the new Oracle API.
…an result after decoding it.
…dency graph when generating PCMArg sets
… because it already does.
…able dependency scanner instead of using libSwiftScan
…ilelist creation.
And add an environment variable to overload the toolchain used to locate the swiftScan dylib
…constructing the `InterModuleDependencyGraph`
…e os-specific directory of the toolchain
To have more information for debugging when failing in one environment (e.g. CI) but not other.
…of dependencies is OS-version dependent.
…lve location of the scanning library.
artemcm
force-pushed
the
DependencyScanLib
branch
from
7f7c0e3 to
c931c60
Compare
This was referenced Feb 4, 2021
…pendency scanning queries if no instance of libSwiftScan is found.
|
@swift-ci please test |
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the dependency scanning action to rely on the newly-introduced
libSwiftScanlibrary, instead of making calls toswift-frontend -scan-dependenciesand parsing back their JSON output.CSwiftScanthat contains the C header which captures all the required symbols fromlibSwiftScan.SwiftScansubdirectory in theSwiftDrivertarget which contains code responsible for interactiosn withlibSwiftScan.SwiftScan) which takes care of initialization, shutdown, and dispatching dependency scanning queries to a library instance.DependencyGraphBuilder.swift) to translate dependency scanning query inputs into the C library expected format and translate the dependency scanning binary output format into the format the driver understands (InterModuleDependencyGraph).Merging this is dependent on swiftlang/swift#34786 being merged and making it into a snapshot toolchain.
Additional cleanup will follow this once clients (SwiftPM) switch to the new API. For example, the notion of a placeholder module will go away completely so all of the placeholder resolution code will become unnecessary.