Skip to content

Add REPL support #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2019
Merged

Add REPL support #43

merged 2 commits into from
Dec 27, 2019

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Dec 19, 2019

The second commit also adds some special handling for single job build plans when in REPL or immediate mode.

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I hadn't checked PRs while on vacation. This looks great, thank you!

@DougGregor
Copy link
Member

@swift-ci please test

@DougGregor DougGregor merged commit 5f5ae14 into swiftlang:master Dec 27, 2019
@owenv
Copy link
Contributor Author

owenv commented Dec 27, 2019

No problem, I wasn’t thinking when I submitted all of these right before the holidays :) Thanks for taking a look!

@DougGregor
Copy link
Member

No worries! Holidays are interesting for open source, when paid contributors go on break and volunteer contributors have more free time. Thanks again! Feel free to tag me if you need more review

@sjavora
Copy link
Contributor

sjavora commented Jan 18, 2020

Hey, @owenv - does this mean REPL Mode should be checked off in the README?

owenv added a commit to owenv/swift-driver that referenced this pull request Jan 19, 2020
REPL mode implemented in swiftlang#43
Immediate mode implemented in swiftlang#36
PCH generation implemented by @cltnschlosser in swiftlang#21
@owenv owenv mentioned this pull request Jan 19, 2020
@owenv
Copy link
Contributor Author

owenv commented Jan 19, 2020

@sjavora yeah, thanks for the reminder. I think #61 brings the todo list more or less up-to-date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants