Skip to content

[NFC] Plumb Through Explicit FileSystem to the Integrator #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jan 27, 2021

This should make tests that build virtual file systems easier to write in the future. While I'm here, sequester some hacks for computing paths into the test fixtures directory.

@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 28, 2021

@swift-ci test

@CodaFi CodaFi force-pushed the lighting-fixtures branch from 90efa44 to 0becbbc Compare January 28, 2021 01:31
@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 28, 2021

@swift-ci test

Copy link
Contributor

@cltnschlosser cltnschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Outside of IncrementalCompilation I think there is still quite a few pieces that assume localFileSystem. If I'm remembering correctly TSCBasic functions don't always allow overriding the FileSystem that is used.

PS: I like your branch name.

@CodaFi
Copy link
Contributor Author

CodaFi commented Jan 28, 2021

@CodaFi CodaFi merged commit c94bd6f into swiftlang:main Jan 28, 2021
@CodaFi CodaFi deleted the lighting-fixtures branch January 28, 2021 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants