Finish Up Driver Dependency Graph Serialization #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CodaFi
commented
Feb 1, 2021
CodaFi
commented
- Serialize external dependencies
- Serialize uses-by-defs
The hashable bound on both key and value for many of the maps implies a derivable Equatable instance that we can pick up.
Also fix a bug where the some fidelity of external dependency nodes was lost because the base name of the path was used instead of the full file path.
Now that we serialize dep graph nodes in one shot, we no longer need this carry-over state.
This completes the serialization of the dependency graph. The idea is to notice that the dependency key for a def may not always appear in the node map, but its uses certainly will (there are scattered invariants, especially in the tracer, that this is true). That means we'll be redundantly serializing nodes if we just naively write out the contents of the uses-by-defs map. Therefore, we establish a linear ordering of dependency nodes - in this case, serialization order - and record memoized node IDs. These are recorded instead, saving 6x the space of a regular serialized node.
|
@swift-ci test |
|
@davidungar I believe this supersedes #450 |
|
Now that we've got the internals nailed down, the remaining concerns I have revolve around serialization orders being run-dependent. I don't know how much it matters in practice yet since the legacy driver didn't really pay much mind here for source file dependency graphs. |
davidungar
approved these changes
Feb 1, 2021
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.