[Incremental] Next step towards cross-module incremental dependencies #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that external dependencies and incremental external dependencies are one and the same, we need to serialize the fingerprints that may or may not be attached to them. # Conflicts: # Sources/SwiftDriver/IncrementalCompilation/ModuleDependencyGraph.swift
|
@swift-ci please test |
CodaFi
reviewed
Feb 4, 2021
| try Bitcode.read(stream: data, using: &visitor) | ||
| } | ||
| } | ||
| catch ReadError.swiftModuleHasNoDependencies { |
There was a problem hiding this comment.
Shouldn't we catch every kind of error here? Like, if more than the signature were to be corrupted and the visitor were to detect it, we should just say the graph is busted and start over.
There was a problem hiding this comment.
I don't think so. This covers the special case of getting an external-dep with a fingerprint, but in the meantime the vendor has been compiled without the flag. But maybe I don't follow; we can discuss offline.
CodaFi
reviewed
Feb 4, 2021
| return integrate(sourceGraph: sourceGraph) | ||
| } | ||
|
|
||
| public func integrate(sourceGraph: SourceFileDependencyGraph) -> Set<Node>? { |
CodaFi
approved these changes
Feb 4, 2021
|
@swift-ci please test macos platform |
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of restructuring; passes the lit tests.