Skip to content

[Incremental] Improve printing for debugging #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

davidungar
Copy link
Contributor

@davidungar davidungar commented Feb 20, 2021

When printing out swiftdeps and swiftmodules for the debugging remarks and in the dot graphs, just use the basename of the swiftdeps and the parent-directory of the swiftmodules. (Because every swiftmodule has the same basename, the parent carries the info.)

Also, get the source name for a SourceFileDependencyGraph from its DependencySource, which is statically guaranteed to be present.

@davidungar davidungar requested review from CodaFi and artemcm February 20, 2021 01:20
@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar
Copy link
Contributor Author

@CodaFi Thanks!

@davidungar davidungar merged commit 923ae3a into swiftlang:main Feb 20, 2021
@davidungar davidungar deleted the retrench branch June 18, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants