Skip to content

[Incremental] Simplify integration logic using a phase concept & Use wrapper types #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 23, 2021
Merged

[Incremental] Simplify integration logic using a phase concept & Use wrapper types #508

merged 10 commits into from
Feb 23, 2021

Conversation

davidungar
Copy link
Contributor

@davidungar davidungar commented Feb 21, 2021 •
edited
Loading

Suggest reviewing commit-by-commit:

  1. Adds a test
  2. Simplifies integration logic by using a phase variable in the ModuleDependencyGraph
  3. Introduces wrappers for sets and arrays in order to use the type system to enforce the transitive closing where needed.

Your feedback is sought!

@davidungar davidungar requested a review from CodaFi February 21, 2021 00:25
@davidungar
Copy link
Contributor Author

@swift-ci please test

CodaFi
CodaFi approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidungar
Copy link
Contributor Author

Thank you, @CodaFi

@davidungar davidungar merged commit 5adec4a into swiftlang:main Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi CodaFi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidungar @CodaFi