Add driver support to specify an overriding output path to record in the index data #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nathawes
force-pushed
the
add-index-unit-output-path
branch
from
0bb1713 to
57c9789
Compare
|
@swift-ci please test |
nathawes
force-pushed
the
add-index-unit-output-path
branch
from
57c9789 to
b990ca9
Compare
|
@swift-ci please test |
nathawes
changed the title
nathawes
force-pushed
the
add-index-unit-output-path
branch
from
b990ca9 to
4652a29
Compare
|
@swift-ci please test |
nathawes
changed the title
artemcm
approved these changes
Mar 5, 2021
| /// Output path to record in the indexing data store | ||
| /// | ||
| /// This is only needed for use as a key in the output file map. | ||
| case indexUnitOutputPath |
There was a problem hiding this comment.
Hmm, I'm now realizing that indexData is the same pattern; but, everything else here is a file type, whereas indexData and indexUnitOutputPath are just directories.
It may be worth refactoring in the future to be a common directory FileType, with an enum associated value for the specific kind of directory. But it's alright in this PR.
…the index data The frontend supports this via new options -index-unit-output-path and -index-unit-output-path-filelist that mirror -o and -output-filelist. These are intended to allow sharing index data across builds in separate directories (so different -o values) that are otherwise equivalent as far as the index data is concerned (e.g. an ASAN build and a non-ASAN build) by supplying the same -index-unit-output-path for both. This change updates the driver to add these new options to the frontend invocation 1) when a new "index-unit-output-path" entry is specified for one or more input files in the -output-file-map json or 2) if -index-file is specified, when a new -index-unit-output-path driver option is passed. Resolves rdar://problem/74816412
nathawes
force-pushed
the
add-index-unit-output-path
branch
from
4652a29 to
9da73a9
Compare
|
@swift-ci test and merge |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend supports this via new options -index-unit-output-path and -index-unit-output-path-filelist that mirror -o and -output-filelist. These are intended to allow sharing index data across builds in separate directories (so different -o values) that are otherwise equivalent as far as the index data is concerned (e.g. an ASAN build and a non-ASAN build) by supplying the same -index-unit-output-path for both.
This change updates the driver to add these new options to the frontend invocation 1) when a new "index-unit-output-path" entry is specified for one or more input files in the -output-file-map json or 2) when -index-file is specified (guaranteeing a single primary input) and a new -index-unit-output-path driver option is passed.
Equivalent change for the old driver here: swiftlang/swift#36272
Resolves rdar://problem/74816412