Block on emitting parseable-output messages in executeJob.
#517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`executeJob` itself runs in a concurrent context. Adding further asynchrnony in emitting parseable-output here isn't worth the trouble it can cause because the performance implications of waiting for these messages to be emitted are likely negligible. Blocking on calls to `jobStarted` and `jobFinished` defines away various possibilities for trouble, for example - the executor concluding its workload and returning before all parseable-output messages have been emitted, potentially confusing the build system in the process. Resolves rdar://74058113
|
@swift-ci please test |
nkcsgexi
approved these changes
Mar 2, 2021
|
Looks OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executeJobitself runs in a concurrent context.Adding further asynchrony in emitting parseable-output here isn't worth the trouble it can cause because the performance implications of waiting for these messages to be emitted are likely negligible.
Blocking on calls to
jobStartedandjobFinisheddefines away various possibilities for error states, for example - the executor concluding its workload and returning before all parseable-output messages have been emitted, potentially confusing the build system in the process.Resolves rdar://74058113