Parse endian-dependent BPF architecture. #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
Merge upstream
merge upstream
owenv
reviewed
Jan 2, 2020
| @@ -574,10 +574,12 @@ extension Triple { | |||
| } | |||
|
|
|||
| private static func parseBPFArch<S: StringProtocol>(_ archName: S) -> Triple.Arch? { | |||
|
|
|||
| let isLittleEndianHost = 1.littleEndian == 1 | |||
There was a problem hiding this comment.
Depending on what stance the project takes on using private language features, we could use #if _endian(little) here. The driver already uses @_exported and @_implementationOnly elsewhere, but on the other hand it might make a bootstrapped build more difficult in the future.
There was a problem hiding this comment.
We'd prefer to use the public language if we can, so let's stick with this.
DougGregor
approved these changes
Jan 3, 2020
| @@ -574,10 +574,12 @@ extension Triple { | |||
| } | |||
|
|
|||
| private static func parseBPFArch<S: StringProtocol>(_ archName: S) -> Triple.Arch? { | |||
|
|
|||
| let isLittleEndianHost = 1.littleEndian == 1 | |||
There was a problem hiding this comment.
We'd prefer to use the public language if we can, so let's stick with this.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from LLVM.