Re-Sync Options Flags #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodaFi
force-pushed
the
across-the-universe
branch
from
3a895ef to
e6d948c
Compare
|
@swift-ci test |
cltnschlosser
approved these changes
Mar 3, 2021
|
Missed some more tests. |
CodaFi
force-pushed
the
across-the-universe
branch
from
e6d948c to
256e046
Compare
|
@swift-ci test |
CodaFi
force-pushed
the
across-the-universe
branch
from
256e046 to
2990548
Compare
|
@swift-ci test macOS |
|
@swift-ci test |
davidungar
suggested changes
Mar 3, 2021
There was a problem hiding this comment.
Although I've left a few comments about pushing the renaming through further, it would be fine to address those in a subsequent PR. The one part that I'm too concerned about to just Approve this at the moment is that it looks like an invocation like ... -disable... -enable... will be handled incorrectly (i.e. not like the legacy driver where the last argument dominates). But maybe I'm missing something?
Now that cross-module incremental builds are controlled by -{enable,disable}-incremental-imports, resync the options and teach merge-modules to propagate the disable flag.
CodaFi
force-pushed
the
across-the-universe
branch
from
2990548 to
c7d8705
Compare
|
@swift-ci test |
davidungar
reviewed
Mar 3, 2021
Comment on lines
+68
to
+70
| if parsedOptions.hasFlag(positive: .disableIncrementalImports, | ||
| negative: .enableIncrementalImports, | ||
| default: false) { |
davidungar
approved these changes
Mar 3, 2021
|
⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that cross-module incremental builds are controlled by -{enable,disable}-incremental-imports, resync the options and teach merge-modules to propagate the disable flag.
rdar://74363450