Do not add precompiled bridging header to a Compile job's display inputs #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Display inputs" are used to convey to the user/client the set of input files that a given compile job will build, e.g. in parseable-output. The driver is relying on the presence of the bridging PCH in `displayInputs` because the `printActions` code relies on `displayInputs`, when they are present. Unlike parseable-output, action printing is used for compiler debugging purposes only, and given that `printActions` is a best-effort emulation of the legacy driver behavior that doesn't really exist in the new driver, we can just as well get away with using `primaryInputs` and ensure `compile` job actions refer to the corresponding precompiled header, to keep the C++ tests passing (`test/Driver/actions.swift` & `test/Driver/actions-dsym.swift`).
cltnschlosser
approved these changes
Mar 5, 2021
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Display inputs" are used to convey to the user/client the set of input files that a given compile job will build, e.g. in parseable-output.
The driver is relying on the presence of the bridging PCH in
displayInputsbecause theprintActionscode relies ondisplayInputs, when they are present. Unlike parseable-output, action printing is used for compiler debugging purposes only, and given thatprintActionsis a best-effort emulation of the legacy driver behavior that doesn't really exist in the new driver, we can just as well get away with usingprimaryInputsand ensurecompilejob actions refer to the corresponding precompiled header, to keep the C++ tests passing (test/Driver/actions.swift&test/Driver/actions-dsym.swift).