Bump swift-argument-parser to 0.4.1 #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
artemcm
approved these changes
Mar 9, 2021
neonichu
force-pushed
the
bump-arg-parser
branch
from
679a16a to
cabbe13
Compare
|
@swift-ci please test |
shahmishal
reviewed
Apr 29, 2021
| @@ -131,7 +131,7 @@ if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil { | |||
| // The 'swift-argument-parser' version declared here must match that | |||
| // used by 'swift-package-manager' and 'sourcekit-lsp'. Please coordinate | |||
| // dependency version changes here with those projects. | |||
| .package(url: "https://github.com/apple/swift-argument-parser.git", .upToNextMinor(from: "0.3.1")), | |||
| .package(url: "https://github.com/apple/swift-argument-parser.git", .upToNextMinor(from: "0.4.1")), | |||
There was a problem hiding this comment.
is there reason we are using 0.4.1, not 0.4.3?
There was a problem hiding this comment.
No strong reason, but I think every package should declare the minimum they need so that we don't necessarily have to coordinate on every single bump. So I kept it at 0.4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will open corresponding PRs for SwiftPM and SourceKit-LSP.