[Incremental] Try a cache for external dependency mod times #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidungar
force-pushed
the
try-mod-time-cache
branch
from
7ef3480 to
b9f3aa5
Compare
|
@swift-ci please test |
|
Do we know if this is the root cause? |
It's suspicious, given the trace in the radar, but I'm waiting to hear from the person reporting the problem to see if it fixes it. I didn't see enough info the radar to reproduce the issue myself. Thus, the "DNM". |
davidungar
changed the title
Fixed the issue, 40 secs -> 2 secs. |
CodaFi
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing a hunch to fix a performance issue.
rdar://75351845