[Incremental] Add a check of the result of running the built app to the IncrementalTestFramework
#540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
CodaFi
approved these changes
Mar 15, 2021
CodaFi
reviewed
Mar 15, 2021
| } | ||
|
|
||
| func run(step: Step, in context: Context) throws -> ProcessResult? { | ||
| let proc = Process(arguments: [context.executablePath(for: self).pathString], |
There was a problem hiding this comment.
/Users/buildnode/jenkins/workspace/pr-swift-driver-macos/branch-main/swift-driver/Tests/IncrementalTestFramework/Module.swift:212:16: error: 'init(arguments:environment:workingDirectory:outputRedirection:verbose:startNewProcessGroup:)' is only available in macOS 10.15 or newer
10:34:10 let proc = Process(arguments: [context.executablePath(for: self).pathString],
10:34:10 ^
10:34:10 /Users/buildnode/jenkins/workspace/pr-swift-driver-macos/branch-main/swift-driver/Tests/IncrementalTestFramework/Module.swift:212:16: note: add 'if #available' version check
10:34:10 let proc = Process(arguments: [context.executablePath(for: self).pathString],
10:34:10 ^
10:34:10 /Users/buildnode/jenkins/workspace/pr-swift-driver-macos/branch-main/swift-driver/Tests/IncrementalTestFramework/Module.swift:211:8: note: add @available attribute to enclosing instance method
10:34:10 func run(step: Step, in context: Context) throws -> ProcessResult? {
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a test to specify an expectation for the stdout, stderr, and error codes. Add such a check to two of the tests.