Skip to content

Improved ARM arch parsing #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2020
Merged

Improved ARM arch parsing #55

merged 1 commit into from
Jan 3, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Jan 2, 2020

A couple of notes:

  • thumb handling still isn't very good, I left a FIXME in the source
  • there might be some opportunities to further improve the test coverage, I'm not very familiar with all of the different manufacturer variants

With this change, I was able to fix a few issues in the Driver integration test suite in addition to the newly enabled Triple tests.

DougGregor
DougGregor approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@DougGregor
Copy link
Member

@swift-ci please test

@DougGregor DougGregor merged commit 005e782 into swiftlang:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenv @DougGregor