[Parsable Output] Break down batch compile jobs into constituent messages #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…primaries Emulating existing C++ driver behavior. - Introduce the concept of a quasiPID, same as in the C++ driver - Break up one job into multiple BeganMessage messages - Fixup individual command lines of each message (w.r.t. `-o` and `-primary-input` options) - Collect ((job, primaryInput) -> quasiPID) information to generate correct `Finished` messages
…vidual batch job primaries Emulating existing C++ driver behavior. - Break up one job into multiple FinishedMessage/SignalledMessage messages
nkcsgexi
reviewed
Mar 26, 2021
…command line for all constituent messages This will make it easier to debug the compiler by taking build command line commands from the build log.
|
@swift-ci please test |
nkcsgexi
approved these changes
Mar 26, 2021
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have, historically, treated batch mode as an implementation detail of the compiler. As a consequence, we have been lying to clients of parsable-output by emitting multiple
began,finished,signalledmessages for each batch job - one message per primary input. The time has come to teach swift-driver to tell the same old lies.Emulating existing C++ driver behavior:
- Cargo-cult the concept of a
quasiPID(https://github.com/apple/swift/blob/main/include/swift/Basic/ParseableOutput.h#L36)
- Break up one compile job with multiple primaries into multiple
[Began|Finished|Signalled]Messagemessages- Collect
((job, primaryInput) -> quasiPID)information to generate correctFinishedmessages- Fixup individual command lines of each
Beganmessage (w.r.t.-oand-primary-inputoptions)- Make
InputOutputMapa part of a.compileJob's state so that we can later query which of its many outputs correspond to a specific primaryResolves rdar://75636235