Skip to content

PrebuiltModuleGen: Allow arm64 interfaces to depend on arm64e interfaces #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2021
Merged

PrebuiltModuleGen: Allow arm64 interfaces to depend on arm64e interfaces #597

merged 2 commits into from
Apr 13, 2021

Conversation

nkcsgexi
Copy link
Contributor

Prebuit modules of arm64e interfaces can be loaded to help building arm64 interfaces.

nkcsgexi added 2 commits April 12, 2021 22:00
@nkcsgexi
support -v
1e9abfa
@nkcsgexi
PrebuiltModuleGen: Allow arm64 interfaces to depend on arm64e interfaces
0b21663 
Prebuit modules of arm64e interfaces can be loaded to help building arm64 interfaces.
@nkcsgexi nkcsgexi requested review from DougGregor and artemcm April 13, 2021 17:13
@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

artemcm
artemcm approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@nkcsgexi nkcsgexi merged commit 7864f83 into swiftlang:main Apr 13, 2021
@nkcsgexi nkcsgexi deleted the verbose branch April 13, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkcsgexi @artemcm