[Triple] Add SubArchs, add validation for thumb architectures #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
…FIXME about parsing thumb architectures.
sjavora
commented
Jan 18, 2020
|
|
owenv
reviewed
Jan 20, 2020
…M enum. Remove duplicate profile switch.
|
@owenv could you please take another look when you have the time? I think I've managed to eliminate most of the nonsensical states. |
owenv
approved these changes
Jan 23, 2020
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
DougGregor
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fills the (currently empty) Triple.SubArch enum based on LLVM and resolves the thumb architectures validation FIXME.
This also meant commented lines in tests related to
subArchs could now be uncommented.