PrebuiltModuleGen: consider failures of Foundation and anything below critical #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… critical Foundation failures can lead to noticable slowness in compilation, so we should consider them critical.
artemcm
reviewed
Apr 16, 2021
| @@ -54,21 +53,25 @@ public class PrebuitModuleGenerationDelegate: JobExecutionDelegate { | |||
| } | |||
| } | |||
|
|
|||
| static func getCriticalOutput(_ job: Job) -> VirtualPath? { | |||
| return job.moduleName == "Foundation" ? job.outputs[0].file : nil | |||
There was a problem hiding this comment.
Before we also considered Swift and _Concurrency critical, do we no longer want to exit early on those?
There was a problem hiding this comment.
This new condition implies the previous conditions as well. If Swift or _Concurrency failed, Foundation will surely fail too.
| @@ -107,13 +107,13 @@ do { | |||
| executor: executor, | |||
| compilerExecutableDir: swiftcPath.parentDirectory) | |||
| let (jobs, danglingJobs) = try driver.generatePrebuitModuleGenerationJobs(with: inputMap, into: outputDir, exhaustive: !coreMode) | |||
| let delegate = PrebuitModuleGenerationDelegate(diagnosticsEngine, verbose) | |||
| let delegate = PrebuitModuleGenerationDelegate(jobs, diagnosticsEngine, verbose) | |||
| do { | |||
| try executor.execute(workload: DriverExecutorWorkload.init(jobs, nil, continueBuildingAfterErrors: true), | |||
| delegate: delegate, numParallelJobs: 128) | |||
| } catch { | |||
| // Only fail the process if stdlib failed | |||
There was a problem hiding this comment.
This comment seems stale now, see comment above.
artemcm
approved these changes
Apr 16, 2021
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundation failures can lead to noticeable slowness in compilation, so we should
consider them critical.