Skip to content

Re-enable testLitDriverDependenciesTests when run on Apple Silicon #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 28, 2021

This test was previously failing in swift CI.
I cannot trigger the failure locally so re-enabling here to test with cross-repository PR testing.

@artemcm artemcm force-pushed the EnableIntegrationTestsOnAllSilicon branch from 98f093a to 67facb1 Compare April 29, 2021 21:44
@artemcm
Copy link
Contributor Author

artemcm commented Apr 29, 2021

The failure was due to having an x86 binary for python3 on the CI bots, which is now resolved.
Running cross-repository test in swiftlang/swift#36936 to confirm, and then this is good to merge.

@artemcm
Copy link
Contributor Author

artemcm commented Apr 29, 2021

@swift-ci please test

@artemcm artemcm requested a review from nkcsgexi April 29, 2021 21:46
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@artemcm artemcm merged commit f27dae0 into swiftlang:main Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants