Introduce a new executable, swift-help, which prints help info for tools #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
approved these changes
Feb 13, 2020
|
@DougGregor No problem, looks like it was just an import conflict with one of my other PRs, should be fixed now. Thanks for the review! |
cltnschlosser
approved these changes
Feb 21, 2020
swift-help is extremely simple, but it allows -help handling to more easily fit into the driver's Job model. A new SwiftOptions module contains the option types and definitions which are shared with the driver.
|
@swift-ci test |
|
Forgot to regenerate testing boilerplate @swift-ci test |
|
@swift-ci test |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-helpis extremely simple, but it allows -help handling to more easily fit into the driver's Job model. A new SwiftOptions module contains the option types and definitions which are shared with the driver.Note that the driver-side test is
#if-ed out right now because there's no good way for the driver to findswift-helpor ensure it's built when running tests yet.Based on the discussion from https://forums.swift.org/t/swift-driver-and-help-documentation-lookup/32881/9, I don't think we'll end up using this for documentation lookup in the future. However, since it's such a small patch I think it's worth it for the architectural benefits alone.