Skip to content

[NFC] Reorganize the tests in IncrementalCompilationTests.swift #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2021
Merged

[NFC] Reorganize the tests in IncrementalCompilationTests.swift #680

merged 2 commits into from
May 26, 2021

Conversation

davidungar
Copy link
Contributor

Bring over a reorganization from main branch (#679) to minimize future conflicts:

The file IncrementalCompilationTests.swift has grown over time and accreted other test classes, encumbering navigation and clarity. Give CrossModuleIncrementalBuildTests and NonincrementalCompilationTests their own files, and reorder the contents of IncrementalCompilationTests.swift to group related tests and their helpers together. Opportunistically, make the helpers private.

This change will facilitate the addition of tests in the future.

David Ungar added 2 commits May 26, 2021 11:02
Reorganize the tests in IncrementalCompilationTests.swift
5c12624 
# Conflicts:
#	Tests/SwiftDriverTests/IncrementalCompilationTests.swift
Fixup cherry-picked commit
1143041
@davidungar davidungar requested a review from a team as a code owner May 26, 2021 21:24
@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar davidungar requested a review from artemcm May 26, 2021 21:26
@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar davidungar merged commit 7bd61e9 into swiftlang:release/5.5 May 26, 2021
@davidungar
Copy link
Contributor Author

Thank you, @akyrtzi and @artem.

@davidungar
Copy link
Contributor Author

rdar://77998890

@davidungar davidungar deleted the release/5.5-with-test-reorg branch July 11, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

@artemcm artemcm artemcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidungar @akyrtzi @artemcm