Skip to content

Pass -warn-on-potentially-unavailable-enum-case frontend flag when building a module #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2021
Merged

Pass -warn-on-potentially-unavailable-enum-case frontend flag when building a module #706

merged 1 commit into from
Jun 10, 2021

Conversation

slavapestov
Copy link
Contributor

Fixes rdar://problem/78306593.

@slavapestov slavapestov requested a review from DougGregor June 9, 2021 02:36
@slavapestov slavapestov mentioned this pull request Jun 9, 2021
Merged
@slavapestov
Copy link
Contributor Author

swiftlang/swift#37843
@swift-ci Please test

davidungar
davidungar approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@davidungar davidungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me!

nkcsgexi
nkcsgexi requested changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check isFrontendArgSupported before inserting this flag? swift-driver may work with an earlier version of the compiler.

@slavapestov
Pass -warn-on-potentially-unavailable-enum-case frontend flag when bu…
3ebf8b4 
…ilding a module

Fixes rdar://problem/78306593.
@slavapestov slavapestov force-pushed the unavailable-enum-case-warning branch from fd1590a to 3ebf8b4 Compare June 10, 2021 06:20
@slavapestov
Copy link
Contributor Author

@nkcsgexi Done!

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

nkcsgexi
nkcsgexi approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slavapestov slavapestov merged commit 3f5f55a into swiftlang:main Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidungar davidungar davidungar approved these changes

@DougGregor DougGregor DougGregor approved these changes

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slavapestov @davidungar @DougGregor @nkcsgexi