Make module naming consistent with the integrated driver when the output filename has 2+ extensions #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a surprising number of tests to fail which wrote something like
-o a.out.optimized
. The C++ driver usesllvm::sys::path::stem
to remove extensions, which would result ina.out
, which is an invalid module name, so the fallback ofmain
would be used.swift-driver
used to remove both extensions, and would name the modulea
. This behavior is clearly better, but I think it's too late to change considering how many tests broke...