Skip to content

[Incremental, Testing] Result builder & dependent removal test #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 15, 2021
Merged

[Incremental, Testing] Result builder & dependent removal test #714

merged 3 commits into from
Jun 15, 2021

Conversation

davidungar
Copy link
Contributor

  1. Use a result builder for the expected diagnostics, and
  2. Add another condition to the file removal test in which the removed file depends on a file that changes

@davidungar davidungar requested a review from artemcm June 14, 2021 16:34
@davidungar
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@davidungar
Copy link
Contributor Author

@swift-ci please test

@artemcm
Copy link
Contributor

artemcm commented Jun 14, 2021

Err, I'd try building your PR with the latest toolchain snapshot from swift.org locally to see if the same failure can be reproduced. Perhaps the latest toolchain has a buggy compiler.

@davidungar
Copy link
Contributor Author

davidungar commented Jun 14, 2021 •
edited
Loading

Err, I'd try building your PR with the latest toolchain snapshot from swift.org locally to see if the same failure can be reproduced. Perhaps the latest toolchain has a buggy compiler.

Good idea! I did that and it did crash. A simple change got it to build. Let's see what happens in ci!

@davidungar
Copy link
Contributor Author

@swift-ci please test

artemcm
artemcm approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks fine to me!

@davidungar
Copy link
Contributor Author

Thank you, @artemcm !

@davidungar davidungar merged commit de5ec16 into swiftlang:main Jun 15, 2021
@davidungar davidungar deleted the result-builder-diags-test-dep-removal branch July 3, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidungar @artemcm