Skip to content

Ensure that verbose (-v) mode applies to in-place execution. #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jun 14, 2021

For compiles which fall under our "in-place execution" flow, ensure that we print the in-place job before executing it if -v was specified.

Resolves rdar://79295614

@artemcm
Copy link
Contributor Author

artemcm commented Jun 14, 2021

@swift-ci please test

For compiles which fall under our "in-place execution" flow, ensure that we print the in-place job before executing it if `-v` was specified.

Resolves rdar://79295614
@artemcm artemcm force-pushed the VerboseImmediateModeFix branch from 3e620d4 to 4c013cc Compare June 14, 2021 18:24
@artemcm
Copy link
Contributor Author

artemcm commented Jun 14, 2021

@swift-ci please test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 14, 2021

From https://ci.swift.org/job/pr-swift-driver-macos/1255/console:

failed: caught error: "signalled(9): 

Hmm, I get the same error when this test invokes swift-frontend from the latest snapshot (June 13, 2021), but not other compilers. Perhaps there is something wrong with this build.

@artemcm
Copy link
Contributor Author

artemcm commented Jun 14, 2021

From https://ci.swift.org/job/pr-swift-driver-macos/1255/console:

failed: caught error: "signalled(9): 

Hmm, I get the same error when this test invokes swift-frontend from the latest snapshot (June 13, 2021), but not other compilers. Perhaps there is something wrong with this build.

It looks like toolchains on swift.org do not have a functioning immediate mode (swift test.swift or directly swift-frontend -interpret) due to a code-signing issue. 😢 That needs to be figured out first before a test like the one in this PR can work.

@artemcm
Copy link
Contributor Author

artemcm commented Jun 16, 2021

From https://ci.swift.org/job/pr-swift-driver-macos/1255/console:

failed: caught error: "signalled(9): 

Hmm, I get the same error when this test invokes swift-frontend from the latest snapshot (June 13, 2021), but not other compilers. Perhaps there is something wrong with this build.

It looks like toolchains on swift.org do not have a functioning immediate mode (swift test.swift or directly swift-frontend -interpret) due to a code-signing issue. 😢 That needs to be figured out first before a test like the one in this PR can work.

Toolchains on swift.org should now have their code-signing issues resolved, so as soon as there is a new development snapshot published, this should be good to go.

@artemcm
Copy link
Contributor Author

artemcm commented Jul 7, 2021

@swift-ci please test

@artemcm artemcm merged commit c733048 into swiftlang:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants