[Dependency Scanning] Add ability to use the dependency scanner's import-prescan mode #717
+190
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
artemcm
force-pushed
the
PreScanCapability
branch
from
1d55311 to
c98af5b
Compare
davidungar
approved these changes
Jun 16, 2021
Comment on lines
+116
to
+120
| // We generate full swiftc -frontend -scan-dependencies invocations in order to also be | ||
| // able to launch them as standalone jobs. Frontend's argument parser won't recognize | ||
| // -frontend when passed directly. |
| } | ||
|
|
||
| private func sanitizeCommandForLibScanInvocation(_ command: inout [String]) { | ||
| // Remove the tool executable to only leave the arguments |
There was a problem hiding this comment.
This comment leaves me wondering what the executable will be?
There was a problem hiding this comment.
Or why there doesn't need to be one?
There was a problem hiding this comment.
Added an explanation. Thanks for catching.
| let moduleVersionedGraphMap: [ModuleDependencyId: [InterModuleDependencyGraph]] | ||
| if (!fallbackToFrontend) { | ||
|
|
||
| if !(try initSwiftScanLib()) { |
There was a problem hiding this comment.
Nit: Would be clearer to break up:
let isSwiftScanLibAvailable = !try initSwiftScanLib()
if isSwiftScanLibAvailable {
There was a problem hiding this comment.
Much clearer, indeed. Fixed.
There was a problem hiding this comment.
PS: Someday, I'd like to meet the llvm engineer who decided to use "true" for "hadError" and find out the rationale.
… mode An ability to do a simple import pre-scan was added to the dependency scanner in swiftlang/swift#34028, with a corresponding libSwiftScan API added later. This PR adds the ability to invoke this import pre-scan from the driver.
artemcm
force-pushed
the
PreScanCapability
branch
from
c98af5b to
e5d6e9f
Compare
|
@swift-ci please test |
|
Thanks, @davidungar! |
|
PPS: Glad the comments were helpful. |
nkcsgexi
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ability to do a simple import pre-scan was added to the dependency scanner in swiftlang/swift#34028, with a corresponding libSwiftScan API added later. It parses input files looking for
importstatements and outputs an array of module names imported in the provided input source files.This PR adds the ability to invoke this import pre-scan from the driver.