[NFC, Incremental] Test effect of a minor version number change on the priors #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
artemcm
approved these changes
Jun 24, 2021
| @@ -218,9 +218,14 @@ extension IncrementalCompilationState.IncrementalDependencyAndInputSetup { | |||
| do { | |||
| graphIfPresent = try ModuleDependencyGraph.read( from: dependencyGraphPath, info: self) | |||
| } | |||
| catch ModuleDependencyGraph.ReadError.mismatchedSerializedGraphVersion { | |||
| diagnosticEngine.emit( | |||
| warning: "Will not do cross-module incremental builds, wrong version of priors at '\(dependencyGraphPath)'") | |||
There was a problem hiding this comment.
It could be helpful to print out the two versions, to give developers a better idea of what "wrong" means here.
There was a problem hiding this comment.
Great idea! Will, do.
| on: localFileSystem, | ||
| compilerVersion: compilerVersion, | ||
| mockSerializedGraphVersion: incrementedVersion) | ||
| // Reset mod time to priors modTime on newly-written priors |
There was a problem hiding this comment.
It's not clear what this comment is referring to.
There was a problem hiding this comment.
Yes, that was a marker for a future PR, but best to remove it for now.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test effect of a minor version number change on the priors, and also add the needed affordances.
Also increment the minor version to reflect the omission of the no-longer-needed serialized inputDependencySourceMap.
Required before landing #728