Skip to content

Do not set DYLD_LIBRARY_PATH to point the installed toolchain/sdk on macOS. #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jun 28, 2021

This has not been a good idea since Swift started shipping in the OS.
The OS runtime is the one we would like Swift scripts to use. Using the installed toolchain can potentially cause sync issues.

Continue setting this variable in other UNIX toolchains, because there is no runtime shipped in the OS there.

Resolves rdar://78951185

This has not been a good idea since Swift started shipping in the OS. The OS runtime is the one we would like Swift scripts to use. Using the installed toolchain can potentially cause sync issues.

Resolves rdar://78951185
@artemcm artemcm requested review from mikeash and nkcsgexi June 28, 2021 23:26
@artemcm
Copy link
Contributor Author

artemcm commented Jun 28, 2021

@swift-ci please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@artemcm artemcm merged commit d4a998b into swiftlang:main Jun 29, 2021
@artemcm artemcm deleted the NoMoreOSToolchainsInScripts branch June 29, 2021 17:55
hamishknight added a commit to hamishknight/swift that referenced this pull request Sep 21, 2024
hamishknight added a commit to hamishknight/swift that referenced this pull request Sep 22, 2024
hamishknight added a commit to hamishknight/swift that referenced this pull request Sep 25, 2024
hamishknight added a commit to hamishknight/swift that referenced this pull request Sep 25, 2024
hamishknight added a commit to hamishknight/swift that referenced this pull request Sep 25, 2024
bnbarham pushed a commit to swiftlang/swift that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants