Skip to content

[5.5][NFC] Fix executable tests by passing in the SDK path explicitly. #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jun 29, 2021

As-is, these tests are sensitive to the environment and are currently failing with:

ld: library not found for -lobjc

Passing in the sdk path explicitly should make them pass and be more resilient.

Resolves rdar://79934188

@artemcm artemcm requested a review from DougGregor June 29, 2021 21:01
@artemcm artemcm requested a review from a team as a code owner June 29, 2021 21:01
@artemcm
Copy link
Contributor Author

artemcm commented Jun 29, 2021

@swift-ci please test

@artemcm artemcm changed the title [5.5] Fix testExplicitModuleBuildEndToEnd by passing in the SDK path explicitly [5.5] Fix executable tests by passing in the SDK path explicitly. Jun 29, 2021
@artemcm
Copy link
Contributor Author

artemcm commented Jun 29, 2021

@swift-ci please test

@artemcm artemcm changed the title [5.5] Fix executable tests by passing in the SDK path explicitly. [5.5][NFC] Fix executable tests by passing in the SDK path explicitly. Jun 29, 2021
@artemcm
Copy link
Contributor Author

artemcm commented Jun 29, 2021

@swift-ci please test

@artemcm artemcm requested a review from nkcsgexi June 29, 2021 21:51
As-is, these tests are sensitive to the environment and are currently failing with:
```
ld: library not found for -lobjc
```
Passing in the sdk path explicitly should make them pass and be more resilient.

Resolves rdar://79934188
@artemcm
Copy link
Contributor Author

artemcm commented Jun 29, 2021

@swift-ci please test

@artemcm artemcm merged commit ad5a5ed into swiftlang:release/5.5 Jun 29, 2021
@artemcm artemcm deleted the FixExplicitTest branch June 29, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants