-
Notifications
You must be signed in to change notification settings - Fork 205
[5.5] Enable checking for -no-toolchain-stdlib-rpath and use it on this repo's binaries before installing #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@varungandhi-apple, would you run the CI on this? |
@swift-ci please test |
Passed CI, ready to merge. |
@DougGregor, would be good to get this in as it fixes a security issue on linux. The latest official prebuilt Swift 5.5 snapshot toolchains use swift-driver by default, which has this ELF RPATH:
This pull will remove that first |
Ping, would be good to get this in. |
@artemcm, anything holding this up? |
@buttaface, we will try and get this in; but, before we do, could you please add an XCTest for this change and then include it in the cherry-pick? Despite the compiler's validation suite, we would still like to have the driver's own test-suite capture these things in XCTests to be more stand-alone w.r.t. the compiler. |
No problem, submitted for trunk in #767, will cherry-pick here once it's in. |
…o's binaries before installing
Cherry-picked the test too. |
Anything holding this up? I think it just needs to be run on the CI with the new test and then we can get it in. |
@swift-ci please test |
Cherry-pick of #732 and #767