Skip to content

Revert "Add an integration with swift-api-digester" #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 6, 2021

Reverts #721

The tests added in this PR are failing in the package bot:
https://ci.swift.org/job/oss-swift-package-macos/5977/console

@artemcm artemcm requested review from owenv, nkcsgexi and shahmishal July 6, 2021 15:44
@artemcm
Copy link
Contributor Author

artemcm commented Jul 6, 2021

@swift-ci please test

@shahmishal shahmishal merged commit c5c10de into main Jul 6, 2021
@shahmishal shahmishal deleted the revert-721-api-digester-integration branch July 6, 2021 16:00
@nkcsgexi
Copy link
Contributor

nkcsgexi commented Jul 6, 2021

Can we fix the test failures and re-merge the PR? CC: @owenv

@owenv
Copy link
Contributor

owenv commented Jul 7, 2021

Sorry, I completely missed those failures somehow. Thanks for reverting @artemcm - I'll investigate and reapply the patch when the issue's fixed. It looks like on the package bots the driver is picking up a swift-api-digester that's incompatible with swift-frontend, I may have missed an override somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants