Skip to content

Reapply swift-api-digester integration #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Jul 7, 2021

This reapplies the patch that caused failure on the package bots, then updates build-script-helper to include swift-api-digester in the list of tools whose lookup is override by the --toolchain flag

@owenv
Copy link
Contributor Author

owenv commented Jul 7, 2021

I'm not 100% sure this is the problem, so I'm going to try and build a toolchain with this patch and see if that succeeds

@swift-ci please test

@owenv
Copy link
Contributor Author

owenv commented Jul 8, 2021

@swift-ci test

@owenv
Copy link
Contributor Author

owenv commented Jul 8, 2021

It looks like the fix in this PR worked - I was able to build a toolchain in the linked PR and verified the tests ran and passed there

@owenv owenv marked this pull request as ready for review July 8, 2021 06:25
@nkcsgexi nkcsgexi merged commit 09845a1 into swiftlang:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants