Skip to content

Alias the Local yams Package to Yams #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Jul 14, 2021

The inverse of #754 when building in Swift-CI because the local package
URL is lowercase...

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 14, 2021

@swift-ci test

@benlangmuir
Copy link
Contributor

Instead of handling two different package names, why not make the package name consistent by adding name: "Yams" in the dependencies? I.e.

    package.dependencies += [
        .package(path: "../swift-tools-support-core"),
        .package(name: "Yams", path: "../yams"), // <==================
        .package(path: "../swift-argument-parser"),
    ]

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 14, 2021

@benlangmuir A much better solution.

@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 14, 2021

@swift-ci test

@CodaFi CodaFi changed the title Use yams When Building Locally Alias the Local yams Package to Yams Jul 14, 2021
The opposite of swiftlang#754 because the local package URL is lowercase, but the
actual repo is uppercase.
@CodaFi
Copy link
Contributor Author

CodaFi commented Jul 14, 2021

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants