Skip to content

[Incremental] Relax currency test to fix ci errors #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

davidungar
Copy link
Contributor

Some lit tests are failing on CI, but they won't fail locally. Based on the output, I suspect the priors currency test is failing and it shouldn't. So let's try relaxing the test: using the build-record mod time instead of the build-start time, and don't do the build end time test, since the build record had better be from the previous run anyway.

@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar
Copy link
Contributor Author

Addresses rdar://80587167

@davidungar davidungar requested a review from artemcm July 15, 2021 02:56
@davidungar davidungar merged commit 93a27ba into swiftlang:main Jul 15, 2021
@davidungar davidungar deleted the stab-at-fixing-irreproducible-ci-failure branch August 19, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants