Add help intro #772
Add help intro #772
Conversation
|
Please test with following pull request: @swift-ci Please Build Toolchain macOS Platform |
|
Please test with the following pull request: @swift-ci Please Build Toolchain Linux Platform |
@bitjammer , I believe that currently |
|
I see. @shahmishal @artemcm is it possible to kick off a build manually with the infrastructure referencing these two PRs? |
You can create an empty PR in the Swift repo and launch a toolchain build referencing both: |
|
Okay I think I will probably hold off on that for the moment, since that could be confusing to the folks that might want it. |
|
Thank you! |
bitjammer
force-pushed
the
acgarland/help-intro
branch
6 times, most recently
from
c1c969e to
602a222
Compare
bitjammer
force-pushed
the
acgarland/help-intro
branch
3 times, most recently
from
b08905f to
54f5dac
Compare
|
@artemcm Do you know who could review the LLDB change for this? swiftlang/llvm-project#3125 |
|
@swift-ci Please test |
|
@artemcm Aside from the conflict, does this look okay to you? |
bitjammer
force-pushed
the
acgarland/help-intro
branch
from
54f5dac to
0256190
Compare
|
@swift-ci Please test |
There was a problem hiding this comment.
These changes look good to me, and I particularly like the REPL intro. Thanks, @bitjammer.
| @@ -32,6 +32,9 @@ | |||
|
|
|||
| /// Dump information about a precompiled Clang module | |||
| case dumpPCM | |||
|
|
|||
| /// Introduce the user to Swift concepts depending on context. | |||
| case intro | |||
There was a problem hiding this comment.
It seems that this PR does not actually make use of this. I am guessing the intent is to have this become the interactive/contextual driver invocation kind in the future when swift no longer launches the REPL?
There was a problem hiding this comment.
Perhaps this calls us to rename this enum into DriverMode, if we're introducing modes of operation to it that may have little to do with the compiler.
bitjammer
force-pushed
the
acgarland/help-intro
branch
from
0256190 to
b7e719e
Compare
|
@swift-ci Please test |
Add an "intro" topic to swift-help, printing the version, welcome message, and available subcommands. When running `swift` by itself, show the intro before entering the REPL. When running `swift-help` directly or via `swift --help`, show all of the available flags as previously. rdar://78280423
bitjammer
force-pushed
the
acgarland/help-intro
branch
from
b7e719e to
2fab30d
Compare
|
Looks like an unrelated assertion failure, will try again in a little while. |
|
@swift-ci Please test |
|
@swift-ci please test |
Add an "intro" topic to swift-help, printing the version, welcome message, and
available subcommands.
When running
swiftby itself, show the intro before entering the REPL.When running
swift-helpdirectly or viaswift --help, show all of theavailable flags as previously.
rdar://78280423
More context: https://forums.swift.org/t/command-line-ux-enhancements-for-swift/50670