[Explicit Module Builds] Add API to specify richer external target module details #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule details Specifically, whether an external target moduel is a framework. This is required to pass this information down to the compiler in order to generate correct auto-linking directives. Part of rdar://81177797
|
@swift-ci please test |
nkcsgexi
approved these changes
Jul 30, 2021
| @@ -50,7 +50,7 @@ let package = Package( | |||
| name: "SwiftDriver", | |||
| dependencies: ["SwiftOptions", "SwiftToolsSupport-auto", | |||
| "CSwiftScan", "Yams"], | |||
| exclude: ["CMakeLists.txt"]), | |||
| exclude: ["CMakeLists.txt", SwiftDriver.docc]), | |||
There was a problem hiding this comment.
This broke the build because "SwiftDriver.docc" isn't a quoted string. Are we not building swift-driver as a package in swift-ci anywhere? /CC @shahmishal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, whether an external target moduel is a framework. This is required to pass this information down to the compiler in order to generate correct auto-linking directives.
Part of rdar://81177797