Improve usability of -l flag

[RAJAGOPALAN-GANGADHARAN]

Resolves SR-14122

Complements PR from bundled driver at swift

[RAJAGOPALAN-GANGADHARAN]

Requesting review : @varungandhi-apple

[RAJAGOPALAN-GANGADHARAN]

Should I use swift-format to format these code? I'm guessing clang-format is not suitable for this

[varungandhi-apple]

Formatting-wise, we're not using swift-format, but please follow the style of the surrounding code. For example, there should be a space before an opening brace.

[varungandhi-apple]

Largely LGTM. Most of the comments are kinda' nitpicks (sorry!) about placement/code simplication. Thank you for your patience and submitting this mirroring PR.

[RAJAGOPALAN-GANGADHARAN]

Thank you for reviewing the code and for your patient feedback. Maybe my next PR would be little bit better I guess :)

[RAJAGOPALAN-GANGADHARAN]

Could someone trigger swift-ci for this please?

[artemcm]

@swift-ci please test

[artemcm]

@swift-ci please test

[varungandhi-apple]

This macOS failure:

Test Case '-[SwiftDriverTests.APIDigesterTests testBaselineGenerationEndToEnd]' started.
/Users/buildnode/jenkins/workspace/pr-swift-driver-macos/branch-main/swift-driver/Sources/SwiftDriverExecution/MultiJobExecutor.swift:307: error: -[SwiftDriverTests.APIDigesterTests testBaselineGenerationEndToEnd] : failed: caught error: "fatalError"
Test Case '-[SwiftDriverTests.APIDigesterTests testBaselineGenerationEndToEnd]' failed (1.235 seconds).

Should've been fixed by #804

swiftlang/swift#38750

@swift-ci smoke test

[RAJAGOPALAN-GANGADHARAN]

This macOS failure:

Test Case '-[SwiftDriverTests.APIDigesterTests testBaselineGenerationEndToEnd]' started.
/Users/buildnode/jenkins/workspace/pr-swift-driver-macos/branch-main/swift-driver/Sources/SwiftDriverExecution/MultiJobExecutor.swift:307: error: -[SwiftDriverTests.APIDigesterTests testBaselineGenerationEndToEnd] : failed: caught error: "fatalError"
Test Case '-[SwiftDriverTests.APIDigesterTests testBaselineGenerationEndToEnd]' failed (1.235 seconds).

Should've been fixed by #804

apple/swift#38750

@swift-ci smoke test

My pr is not up to date with upstream I guess.

[varungandhi-apple]

It should be running tests after (locally) merging your PR into main. Since 804 was already merged into main, I don't think you should need to update your PR. Little confused by how it is still failing. 😕

[varungandhi-apple]

@swift-ci smoke test macOS

[RAJAGOPALAN-GANGADHARAN]

It should be running tests after (locally) merging your PR into main. Since 804 was already merged into main, I don't think you should need to update your PR. Little confused by how it is still failing. 😕

Oh I see, let me know if I have to do something else

[artemcm]

@swift-ci test macOS platform

[RAJAGOPALAN-GANGADHARAN]

Oh looks its passed, may I know what's the diff between "@swift-ci test macOS platform" and "@swift-ci smoke test macOS" ?

[artemcm]

Oh looks its passed, may I know what's the diff between "@swift-ci test macOS platform" and "@swift-ci smoke test macOS" ?

This repository does not support smoke test AFAIK.

[varungandhi-apple]

My bad, I'm used to smoke test from working on the apple/swift repository. You can find the difference explained here: https://github.com/apple/swift/blob/main/docs/ContinuousIntegration.md#pull-request-testing