Add support for loading supported features from share/swift/features.json #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nkcsgexi
force-pushed
the
json-feature
branch
from
2b68778 to
28ed9b0
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
artemcm
reviewed
Sep 22, 2021
| @@ -344,4 +344,24 @@ public extension Driver { | |||
| .parentDirectory // bin | |||
| .parentDirectory // toolchain root | |||
| } | |||
|
|
|||
| static func computeSupportedCompilerFeatures(of toolchain: Toolchain, | |||
There was a problem hiding this comment.
Could we please move this to be alongside the equivalent supported-flags query in EmitSupportedFeaturesJob.swift?
nkcsgexi
force-pushed
the
json-feature
branch
from
752799c to
6d3a6da
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.