[5.5] Bug fixes and test updates for emit-module-separately #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to make this feature the default soon. Let's add a flag to disable it beforehand to be safe. Once emit-module-separately is the default, passing this flag will force the driver to rely on the merge-module incremental build mode. rdar://78228466
With emit-module-separately by default the compiler no longer use compile jobs for -emit-module.
The linker uses the swiftmodule file generated by the emit-module job.
…eduled This prevents generating duplicate files and feeding duplicated diagnostics to Xcode.
|
@swift-ci Please test |
This was referenced Sep 22, 2021
artemcm
approved these changes
Sep 22, 2021
airspeedswift
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in fixes to support using and testing emit-module-separately in 5.5. This does not enable emit-module-separately by default, merge-module remains the default.
Cherry-pick of #668 and #790.
This is aligned with the compiler-side swiftlang/swift#39249.