build: remove bogus dependency on swift-driver
#859
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SwiftDriverTests` target should not depend on the `swift-driver` target. The latter is the executable binary. This was noticed when trying to port the swift-driver project to Windows. The Windows linker caught the fact that the `main` entry point was multiply defined, once from the test binary, and once from the `swift-driver` executable. Do not add the `swift-driver` to the dependency set as that will cause a link dependency, which results in the multiply defined symbols.
|
CC: @CodaFi |
|
@swift-ci please test |
CodaFi
approved these changes
Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SwiftDriverTeststarget should not depend on theswift-drivertarget. The latter is the executable binary. This was noticed when
trying to port the swift-driver project to Windows. The Windows linker
caught the fact that the
mainentry point was multiply defined, oncefrom the test binary, and once from the
swift-driverexecutable. Donot add the
swift-driverto the dependency set as that will cause alink dependency, which results in the multiply defined symbols.