SwiftDriverTests: disable some tests #866
Conversation
These tests explicitly hardcode the macOS triple into the test, making them inherently non-portable. Just disable the tests.
|
@swift-ci please test |
|
It's weird that these tests were successfully running on linux. Seems like there is probably a bug somewhere? |
|
Yeah, there is something definitely odd going on here. I can hold off on merging this if you want to take a look @cltnschlosser. I am building with a local patch to implement Windows support and just trying to get through the test suite. But I believe that the version that I have is better than the version that has been up as a PR for a while (it matches the C++ driver better and supports a bit more functionality). |
|
No feel free, just an observation. |
|
That observation has been bugging me too. I don't understand why this passes on Linux. Am I mistaken in that this should be limited to macOS? |
|
I'm still not 100% certain about which way this should lean (that is if this is a bug on the Windows side or the Linux side). However, for the moment, going to go ahead with this as there are definitely issues with using the hardcoded triple and this allows the explicit module build tests to pass which allows some level of tracking for issues on the windows toolchain. |
These tests explicitly hardcode the macOS triple into the test, making
them inherently non-portable. Just disable the tests.