-
Notifications
You must be signed in to change notification settings - Fork 205
SwiftDriver: initial (incomplete) windows port #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| //===------------- WindowsExtensions.swift - Windows Extensions -----------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import Foundation | ||
|
|
||
| internal func executableName(_ name: String) -> String { | ||
| #if os(Windows) | ||
| if name.suffix(from: name.index(name.endIndex, offsetBy: -4)) == ".exe" { | ||
| return name | ||
| } | ||
| return "\(name).exe" | ||
| #else | ||
| return name | ||
| #endif | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
Sources/SwiftDriver/Jobs/WindowsToolchain+LinkerSupport.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| //===--------------- WindowsToolchain+LinkerSupport.swift -----------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors | ||
| // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| // | ||
| // See https://swift.org/LICENSE.txt for license information | ||
| // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| import TSCBasic | ||
| import SwiftOptions | ||
|
|
||
| extension WindowsToolchain { | ||
| public func addPlatformSpecificLinkerArgs(to commandLine: inout [Job.ArgTemplate], | ||
| parsedOptions: inout ParsedOptions, | ||
| linkerOutputType: LinkOutputType, | ||
| inputs: [TypedVirtualPath], | ||
| outputFile: VirtualPath, | ||
| shouldUseInputFileList: Bool, | ||
| lto: LTOKind?, | ||
| sanitizers: Set<Sanitizer>, | ||
| targetInfo: FrontendTargetInfo) | ||
| throws -> AbsolutePath { | ||
| let targetTriple = targetInfo.target.triple | ||
|
|
||
| if !targetTriple.triple.isEmpty { | ||
| commandLine.appendFlag("-target") | ||
| commandLine.appendFlag(targetTriple.triple) | ||
| } | ||
|
|
||
| switch linkerOutputType { | ||
| case .staticLibrary: | ||
| break | ||
| case .dynamicLibrary: | ||
| commandLine.appendFlag("-shared") | ||
| case .executable: | ||
| break | ||
| } | ||
|
|
||
| // Select the linker to use. | ||
| if let arg = parsedOptions.getLastArgument(.useLd) { | ||
| commandLine.appendFlag("-fuse-ld=\(arg.asSingle)") | ||
| } else if lto != nil { | ||
| commandLine.appendFlag("-fuse-ld=lld") | ||
| } | ||
|
|
||
| switch lto { | ||
| case .some(.llvmThin): | ||
| commandLine.appendFlag("-flto=thin") | ||
| case .some(.llvmFull): | ||
| commandLine.appendFlag("-flto=full") | ||
| case .none: | ||
| break | ||
| } | ||
|
|
||
| // FIXME(compnerd): render `-Xlinker /DEBUG` or `-Xlinker /DEBUG:DWARF` with | ||
| // DWARF + lld | ||
|
|
||
| // Rely on `-libc` to correctly identify the MSVC Runtime Library. We use | ||
| // `-nostartfiles` as that limits the difference to just the | ||
| // `-defaultlib:libcmt` which is passed unconditionally with the `clang` | ||
| // driver rather than the `clang-cl` driver. | ||
| commandLine.appendFlag("-nostartfiles") | ||
|
|
||
| // TODO(compnerd) investigate the proper way to port this logic over from | ||
| // the C++ driver. | ||
|
|
||
| // Since Windows has separate libraries per architecture, link against the | ||
| // architecture specific version of the static library. | ||
| commandLine.appendFlag(.L) | ||
| commandLine.appendPath(VirtualPath.lookup(targetInfo.runtimeLibraryImportPaths.last!.path)) | ||
|
|
||
| // FIXME(compnerd) figure out how to ensure that the SDK relative path is | ||
| // the last one | ||
| commandLine.appendPath(VirtualPath.lookup(targetInfo.runtimeLibraryImportPaths.last!.path) | ||
| .appending(component: "swiftrt.obj")) | ||
|
|
||
| commandLine.append(contentsOf: inputs.compactMap { (input: TypedVirtualPath) -> Job.ArgTemplate? in | ||
| switch input.type { | ||
| case .object, .llvmBitcode: | ||
| return .path(input.file) | ||
| default: | ||
| return nil | ||
| } | ||
| }) | ||
|
|
||
| for framework in parsedOptions.arguments(for: .F, .Fsystem) { | ||
| commandLine.appendFlag(framework.option == .Fsystem ? "-iframework" : "-F") | ||
| try commandLine.appendPath(VirtualPath(path: framework.argument.asSingle)) | ||
| } | ||
|
|
||
| if let sdkPath = targetInfo.sdkPath?.path { | ||
| commandLine.appendFlag("-I") | ||
| commandLine.appendPath(VirtualPath.lookup(sdkPath)) | ||
| } | ||
|
|
||
| if let stdlib = parsedOptions.getLastArgument(.experimentalCxxStdlib) { | ||
| commandLine.appendFlag("-stdlib=\(stdlib.asSingle)") | ||
| } | ||
|
|
||
| // FIXME(compnerd) render asan/ubsan runtime link for executables | ||
|
|
||
| if parsedOptions.contains(.profileGenerate) { | ||
| commandLine.appendFlag("-Xlinker") | ||
| // FIXME(compnerd) wrap llvm::getInstrProfRuntimeHookVarName() | ||
| commandLine.appendFlag("-include:__llvm_profile_runtime") | ||
| commandLine.appendFlag("-lclang_rt.profile") | ||
| } | ||
|
|
||
| for option in parsedOptions.arguments(for: .Xlinker) { | ||
| commandLine.appendFlag(.Xlinker) | ||
| commandLine.appendFlag(option.argument.asSingle) | ||
| } | ||
| // TODO(compnerd) is there a separate equivalent to OPT_linker_option_group? | ||
| try commandLine.appendAllArguments(.XclangLinker, from: &parsedOptions) | ||
|
|
||
| if parsedOptions.contains(.v) { | ||
| commandLine.appendFlag("-v") | ||
| } | ||
|
|
||
| commandLine.appendFlag("-o") | ||
| commandLine.appendPath(outputFile) | ||
|
|
||
| // TODO(compnerd) handle static libraries | ||
| return try getToolPath(.clang) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess it would be nice if the environment variables were consistent across platforms. So windows doesn't always have an extra
_EXEin its variables.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that we will need to resolve this, but I think that doing that subsequently is better than trying to address everything immediately.