SwiftDriverTests: conditionalise exitStatus
#884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not have a concept of signals. As such, we cannot have an exit status of `signalled`. This allows the test suite to build, though this test will currently fail.
|
@swift-ci please test |
|
Does it make sense to just skip the whole test? |
|
I guess the question is, what is the intent of the test? Does it care about signalling or does it care about the fact that it can process invalid termination? Because ultimately signals are just a proxy for the fact that there was an abnormal termination, which does does have a concept of, just not in the form of signals. |
artemcm
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not have a concept of signals. As such, we cannot have an
exit status of
signalled. This allows the test suite to build, thoughthis test will currently fail.